Skip to content

feat: add new apispec for the new amalthea sessions#360

Merged
olevski merged 1 commit intorelease-amaltheas-migrationfrom
feat-add-new-sessions-apispec
Sep 20, 2024
Merged

feat: add new apispec for the new amalthea sessions#360
olevski merged 1 commit intorelease-amaltheas-migrationfrom
feat-add-new-sessions-apispec

Conversation

@olevski
Copy link
Copy Markdown
Member

@olevski olevski commented Aug 20, 2024

This will be used only in Renku v2 with the new Amalthea operator.

@olevski olevski requested a review from a team as a code owner August 20, 2024 15:21
@olevski olevski requested a review from andre-code August 20, 2024 15:21
@coveralls
Copy link
Copy Markdown

coveralls commented Aug 20, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10709956586

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 7 unchanged lines in 5 files lost coverage.
  • Overall coverage decreased (-0.02%) to 90.572%
Files with Coverage Reduction New Missed Lines %
components/renku_data_services/base_models/core.py 1 91.4%
components/renku_data_services/connected_services/db.py 1 82.18%
components/renku_data_services/crc/db.py 1 87.81%
components/renku_data_services/storage/blueprints.py 1 94.76%
components/renku_data_services/crc/blueprints.py 3 93.19%
Totals Coverage Status
Change from base Build 10701549852: -0.02%
Covered Lines: 9290
Relevant Lines: 10257
💛 - Coveralls

andre-code
andre-code requested changes Aug 26, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@andre-code andre-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The API specification looks good overall. Aside from my comment below, it handles all the cases currently used for Renku 2.0.

Comment thread components/renku_data_services/notebooks/api.spec.yaml Outdated
Comment thread components/renku_data_services/notebooks/api.spec.yaml
Comment thread components/renku_data_services/notebooks/api.spec.yaml
- project_id
- launcher_id
type: object
SessionResponse:
Copy link
Copy Markdown
Contributor

@andre-code andre-code Aug 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which part here represents the sessionId?

Copy link
Copy Markdown
Member Author

@olevski olevski Aug 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's the name field.

@olevski
Copy link
Copy Markdown
Member Author

olevski commented Aug 27, 2024 •
edited
Loading

This change is part of the following stack:

Change managed by git-spice.

This was referenced Aug 27, 2024
Merged
Closed
@olevski olevski force-pushed the feat-add-new-sessions-apispec branch from 5a4dfa2 to a4f95d8 Compare August 27, 2024 19:22
@olevski olevski mentioned this pull request Aug 27, 2024
Merged
@olevski olevski force-pushed the feat-add-new-sessions-apispec branch from a4f95d8 to 3da7dc0 Compare August 28, 2024 09:26
@olevski
Copy link
Copy Markdown
Member Author

olevski commented Aug 28, 2024

@andre-code I have addressed all your comments. The other change in addition to the changes from your comments is that now the status is simpler as we discussed during the status update yesterday.

Now all you get to track progress is the number of total containers and the number of ready containers.

Please note that once a session is created the total number of containers may be zero for the first few request as the session is getting created and things are being created. But after 1 or 2 requests the number will be good. I can fix this it just requires a bit more changes on the amalthea side.

@Panaetius Panaetius force-pushed the feat-add-new-sessions-apispec branch from 3da7dc0 to a4f95d8 Compare August 30, 2024 08:21
@Panaetius Panaetius mentioned this pull request Aug 30, 2024
Merged
@olevski olevski force-pushed the feat-add-new-sessions-apispec branch from a4f95d8 to 3da7dc0 Compare August 30, 2024 08:31
@olevski olevski mentioned this pull request Sep 4, 2024
Merged
@olevski olevski force-pushed the feat-add-new-sessions-apispec branch from 3da7dc0 to ea7da1f Compare September 4, 2024 21:41
@olevski olevski mentioned this pull request Sep 17, 2024
Merged
@olevski
feat: add new apispec for the new amalthea sessions
5d7e340 
This will be used only in Renku v2 with the new Amalthea operator.
@olevski olevski force-pushed the feat-add-new-sessions-apispec branch from ea7da1f to 5d7e340 Compare September 20, 2024 08:55
@olevski olevski changed the base branch from main to release-amaltheas-migration September 20, 2024 09:07
@olevski olevski merged commit b3a4da7 into release-amaltheas-migration Sep 20, 2024
10 checks passed
@olevski olevski deleted the feat-add-new-sessions-apispec branch September 20, 2024 09:46
olevski added a commit that referenced this pull request Sep 20, 2024
@olevski
feat: add new apispec for the new amalthea sessions (#360)
ee3dc74
olevski added a commit that referenced this pull request Sep 23, 2024
@olevski
feat: add new apispec for the new amalthea sessions (#360)
0153859
olevski added a commit that referenced this pull request Sep 25, 2024
@olevski
feat: add new apispec for the new amalthea sessions (#360)
0f060bf
olevski added a commit that referenced this pull request Oct 2, 2024
@olevski
feat: add new apispec for the new amalthea sessions (#360)
f489378
olevski added a commit that referenced this pull request Oct 4, 2024
@olevski
feat: add new apispec for the new amalthea sessions (#360)
da758ce
olevski added a commit that referenced this pull request Oct 8, 2024
@olevski
feat: add new apispec for the new amalthea sessions (#360)
6555869
olevski added a commit that referenced this pull request Oct 22, 2024
@olevski
feat: add new apispec for the new amalthea sessions (#360)
024c770
olevski added a commit that referenced this pull request Oct 28, 2024
@olevski
feat: add new apispec for the new amalthea sessions (#360)
5fb6793
olevski added a commit that referenced this pull request Oct 28, 2024
@olevski
feat: add new apispec for the new amalthea sessions (#360)
4d55808
olevski added a commit that referenced this pull request Oct 30, 2024
@olevski
feat: add new apispec for the new amalthea sessions (#360)
58ec4f9
olevski added a commit that referenced this pull request Oct 31, 2024
@olevski
feat: add new apispec for the new amalthea sessions (#360)
3c6254b
olevski added a commit that referenced this pull request Nov 1, 2024
@olevski
feat: add new apispec for the new amalthea sessions (#360)
f1334eb
olevski added a commit that referenced this pull request Nov 4, 2024
@olevski
feat: add new apispec for the new amalthea sessions (#360)
e175947
olevski added a commit that referenced this pull request Nov 6, 2024
@olevski
feat: add new apispec for the new amalthea sessions (#360)
4a91275
olevski added a commit that referenced this pull request Nov 8, 2024
@olevski
feat: add new apispec for the new amalthea sessions (#360)
5a81d16
olevski added a commit that referenced this pull request Nov 11, 2024
@olevski
feat: add new apispec for the new amalthea sessions (#360)
faa2246
olevski added a commit that referenced this pull request Nov 11, 2024
@olevski
feat: add new apispec for the new amalthea sessions (#360)
60bfd8c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andre-code andre-code andre-code requested changes

+1 more reviewer

@Panaetius Panaetius Panaetius approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@olevski @coveralls @Panaetius @andre-code